Enabling phrase triggering of Python PreCommit#3942
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 6, 2017
Merged
Conversation
Member
|
It should also automatically trigger on any pull request, and then "Retest this please" will trigger it. |
Member
Author
|
Yes, but wouldn't that also trigger Java tests? I'd like to be able to run only the Python PreCommit tests if those are the ones I care about. Does that seem reasonable? |
|
Changes Unknown when pulling a4cd96c on pabloem:patch-2 into ** on apache:master**. |
Member
Author
|
Retest this please. |
1 similar comment
Member
Author
|
Retest this please. |
Contributor
|
Agree with your justification Pablo -- LGTM |
jasonkuster
approved these changes
Oct 6, 2017
Member
Author
|
Can you merge please? - Thanks |
Member
|
Yea LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r: @jasonkuster
cc: @kennknowles